Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused facade to remove ide helper error message #98

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

ziming
Copy link

@ziming ziming commented Aug 3, 2023

I have @php artisan ide-helper:generate in my composer.json post-update

https://github.com/barryvdh/laravel-ide-helper

and everytime i do composer update

I will get this error message

Exception: Target class [filament-fullcalendar] does not exist.
Skipping \Saade\FilamentFullCalendar\Facades\FilamentFullCalendar.

It's a small annoyance but if I don't see it everytime it is even better

This package does not use the facade at all. the FilamentFullCalendar class is also completely empty with no methods (I did not delete that but you may want to)

https://github.com/saade/filament-fullcalendar/blob/main/src/FilamentFullCalendar.php

@saade saade closed this Aug 9, 2023
@saade saade reopened this Aug 9, 2023
@saade saade changed the base branch from main to 2.x September 26, 2023 19:07
@saade saade merged commit 6ace9a2 into saade:2.x Sep 26, 2023
2 checks passed
@ziming ziming deleted the delete-facade branch September 27, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants